Skip to content

bug: restore old app name #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OmkarPh merged 1 commit into from
Dec 9, 2023
Merged

bug: restore old app name #615

OmkarPh merged 1 commit into from
Dec 9, 2023

Conversation

@dotarjun
Copy link
Contributor

@dotarjun dotarjun commented Nov 28, 2023

fixes #613

OmkarPh
OmkarPh requested changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@OmkarPh OmkarPh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dotarjun

The goal is to have the app name changed when packaging it, not in the About file
You'll have to change the packager config, and check the built release file name in out/

@dotarjun
bug: restore old name
3d215db 
Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
@OmkarPh
Copy link
Collaborator

OmkarPh commented Dec 9, 2023

Thanks @dotarjun
PS: Next time please sync your fork with the latest develop

@OmkarPh OmkarPh merged commit 51c96eb into aboutcode-org:develop Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmkarPh OmkarPh OmkarPh requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore Old app name

2 participants

@dotarjun @OmkarPh