-
-
Notifications
You must be signed in to change notification settings - Fork 81
Diff modal for Matched text & Rule text in Matches table #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
2a70012 to
5c2bca4
Compare
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
A good example with many variations to test this on.s Notice also the matched text sometimes has |
Actually, I had opened this PR before the call this week, the diff you see below is what we discussed in the call (it has unnecessary diffs like spaces, newlines, etc) The diff on top is the final diff we will have.
|
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
hi @AyanSinhaMahapatra |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
@OmkarPh tested out the diffs, this is looking great! Much more improved from before and works great on most cases! There are a couple more edge case to handle btw:
Testing this out more, but once this is working great on most of the cases, we can merge and track more edge cases separately in the issue. |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Ignore this part ^. This is being handled correctly. The result JSON did not have any license references data so that's why it showed that. One other point on that btw: let's say in the matched text/diff modal when we don't have references data, instead of saying: Similarly there are cases where there are no rule texts, as we create synthetic rules for showing matches:
For these three cases of synthetic rules we can have seperate doc strings which can be shown. |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
I've handled the mentioned cases with relevant messages (let me know if the text needs any change) |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmkarPh LGTM! thanks++
This works perfectly thanks! I've tested out the new changes and all the issues in the comments above are resolved. This is ready to merge.





Fixes #561