GSoC`22 - Refactored workbench to react+typescript v4.0 & schema updates for latest version #532

OmkarPh · 2022-08-15T14:50:06Z

Signed-off-by: Omkar Phansopkar omkarphansopkar@gmail.com

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

* test Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Try CI release Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated CI Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * trial 1 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * t2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * t3 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Platform specific tar names Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml again Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml againn Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix workflow yml againnn Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Add new release workflow job Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t7 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8.1 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8.2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8.3 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8.5 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t8.5 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t9 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t9 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t9.1 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t9.2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated release workflow job t9.3 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Added release workflow for linux & windows Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Matrix for OS Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release beta 4.0.0 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test3 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test4 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test5 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release test with get tag Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Update for push Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Beta release Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Arm beta Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release arm test2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Release arm test3 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Fix invalid os Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Finalized Release yml Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Removed residue code Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

…windows instead of tar Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

* Powershell script in python t1 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Powershell script in python t2 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Removed comments Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Removed residue Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

* Basic interface for top level packages Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Completed package & dependency definitions Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Type-classified packages Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated UI for beta2 release Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Created primary fields and badges Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh · 2022-09-17T06:27:32Z

Try out - https://github.com/OmkarPh/scancode-workbench/releases/tag/v4.0.0_beta4

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

AyanSinhaMahapatra

This looks great, thanks! We should merge and cut a release after reviewing.

@pombredanne could you try out and approve?

steven-esser

Thanks for the hard work @OmkarPh, this is great.

I will leave it to @pombredanne and the nexB team to determine how/when they want to merge this in and release a new version.

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

notes.txt

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

pombredanne · 2022-11-21T17:10:25Z

credits.txt

@@ -0,0 +1,4 @@
+@TODO - Add these in about section -


We need an ABOUT file for this.

hey, @pombredanne
can you share an example or basic Outline for this ABOUT file
@AyanSinhaMahapatra , maybe you've some inputs on this

@OmkarPh sorry I missed this,

for a package this might look like: https://github.com/nexB/thirdparty-packages/blob/main/pypi/Babel-2.10.1.tar.gz.ABOUT

for a file: it could be like: https://github.com/nexB/scancode-toolkit/blob/develop/src/scancode/pool.py.ABOUT

Basically a download_url with license/copyright information and any other info you can find for giving credits/attribution. You might also need to add a copy of the license file if applicable, like the second example above in some cases depending on the license.

I've created about file for the image asset https://github.com/OmkarPh/scancode-workbench/blob/v4.0-react-typescript/assets.ABOUT
I also added it in attribution window

Rest, I couldn't find any piece of code that I've directly copied from the internet
except for the official docs

Use license instead of usage_terms, and the about file should be just beside the file which you are describing, and the filename would be: addFiles.png.ABOUT.

The terms and conditions in https://storyset.com/terms looks good to me, since it says The authorization to use the Storyset Content shall be free provided that any use of the Storyset Content by the User is credited to the Company/Website as stated by the Company from time to time. but this needs to also be reviewed by @pombredanne .

Thanks!

The TOS are significantly more complex than the "Authorization to use...." sentence so we need to look at the whole TOS. I do not see a problem, but we need to review in more detail.

updated: https://github.com/OmkarPh/scancode-workbench/blob/v4.0-react-typescript/src/assets/images/Addfiles.png.ABOUT

martin-langhoff · 2022-12-01T23:04:40Z

Testing your PR

branch builds on my Mac OS 12.6.1 with Node from Brew (whereas develop is broken on node-gyp)
tested with an input report.json built with latest 'develop' commit in scancode-toolkit, the test run was over the git source code repo
Import worked well
In dashboard, Copyright Holders looks a bit odd (screencap below)
License info dashboard had no data, this is incorrect (JSON file has license data)

martin-langhoff · 2022-12-01T23:06:46Z

Also, npm install had all sorts of complaints about versions being stale and in conflict. So the good news is npm-gyp behaved. But npm thinks deps are stale and the developer should run npm audit to figure out what deps have critical updates.

OmkarPh · 2022-12-03T17:49:54Z

Thanks for your review. @martin-langhoff

branch builds on my Mac OS 12.6.1 with Node from Brew (whereas develop is broken on node-gyp)

yeah, 'develop' is the legacy code, so we don't expect wonders from it ;)

tested with an input report.json built with latest 'develop' commit in scancode-toolkit, the test run was over the git source code repo

the schema in workbench needs some minor updates to support the latest scancode-toolkit scans, that's our next goal

In dashboard, Copyright Holders looks a bit odd (screencap below)

we've to look for a better charts library, that handles such responsive issues

License info dashboard had no data, this is incorrect (JSON file has license data)

it's again because of non-updated schema ;)

PS: In case you want to use the workbench for usage, other than testing
You can use this for now https://github.com/OmkarPh/scancode-workbench/releases/tag/v4.0.0_beta4

OmkarPh · 2023-01-06T15:47:51Z

hi @pombredanne
any update on this :)

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

* Updated schema for header info Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated schema & ux for license detections, packages Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * License detections explorer menu Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Removed residue columns for older license format Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Merged license keys with URLs in match table Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Testing License keys parser Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Completed license detection match table UI Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Updated UX & schema for latest output LicenseDetections Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Tableview scoped filters, Header-less import, filename in titlebar, format & crash fixes Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Ignored directories when preparing chart data Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Package_data fields, file & package info dashboard, chart empty labels Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * Completed all pie charts Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> * New window, Info dash fixes, Completed matches table, fixed flatFiles, spdx parsing for matches Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> --------- Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

…f detection.identifier) Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

AyanSinhaMahapatra

@OmkarPh Thanks a lot for the amazing work! This is fantastic. I've tested out the linux build locally and works great. So please go ahead and merge this as is and we'll track more improvements separately. Thank you for the quick fixes on the JSONStreams dependency issue and other open issues opened by @mjherzog too.

A few nits: we need to update the sample scans and readme to be consistent with our workbench supported versions on scancode-toolkit and also document this well enough so there's no confusion, but I'll open a separate issue for that.

Thanks ++ again

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Refactored workbench to react+typescript v4.0

f81fa95

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh requested review from AyanSinhaMahapatra, pombredanne and steven-esser August 15, 2022 14:50

OmkarPh added 3 commits August 16, 2022 14:36

Added support for latest schema, removed unused libs and code

0a6c21e

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Chart tooltips, scroll gutter fix, removed residues

30be02b

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Added latest UI gif in readme

b51019b

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh force-pushed the v4.0-react-typescript branch from 6e0b541 to b51019b Compare August 17, 2022 12:11

OmkarPh added 7 commits August 19, 2022 00:00

Fixed existing history item bug

b197168

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Implemented file drag & drop and updated workflow to generate zip on …

fcafeca

…windows instead of tar Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Updated column filter options, remove entry button, UI improvements

09abaed

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Updated schema to store top level packages & dependencies too

b751128

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Updated Release data

9662dbd

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

AyanSinhaMahapatra approved these changes Sep 19, 2022

View reviewed changes

OmkarPh changed the title ~~Refactored workbench to react+typescript v4.0~~ GSoC`22 - Refactored workbench to react+typescript v4.0 Sep 19, 2022

steven-esser approved these changes Sep 20, 2022

View reviewed changes

OmkarPh added 5 commits September 25, 2022 13:18

Polished UI in packages explorer tree

4dd2c11

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Removed unused logs

8b5a93a

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Updated deps & config changes

323af9c

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Made pie charts responsive

c7588e6

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Updated chart fallbacks with links to cli options

d0e5718

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

pombredanne reviewed Nov 21, 2022

View reviewed changes

notes.txt Outdated Show resolved Hide resolved

Updated fallback links, removed residue notes file

4dd0aa3

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

pombredanne reviewed Nov 21, 2022

View reviewed changes

pombredanne mentioned this pull request Dec 1, 2022

Support latest scancode toolkit #525

Closed

OmkarPh added 2 commits February 14, 2023 23:50

Updated attribution & about file for assets

73fce61

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

Fixed license for image file

687b4e8

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh requested a review from pombredanne February 15, 2023 11:15

AyanSinhaMahapatra mentioned this pull request Mar 28, 2023

SCWB 4 does not display any License data for a Scan from SCTK 32 #548

Closed

OmkarPh added 2 commits April 7, 2023 01:31

Fixed matches parser not working for prev toolkit versions (absence o…

a138e17

…f detection.identifier) Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh changed the title ~~GSoC`22 - Refactored workbench to react+typescript v4.0~~ GSoC`22 - Refactored workbench to react+typescript v4.0 & schema updates for latest version Apr 7, 2023

Fixed jsonstream library letter case

ce61851

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

AyanSinhaMahapatra approved these changes Apr 13, 2023

View reviewed changes

Fixed debug residue

84d2e20

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

OmkarPh merged commit bd7c7b1 into aboutcode-org:v4.0-react-typescript Apr 13, 2023

Uh oh!

GSoC`22 - Refactored workbench to react+typescript v4.0 & schema updates for latest version #532

GSoC`22 - Refactored workbench to react+typescript v4.0 & schema updates for latest version #532

Uh oh!

Conversation

OmkarPh commented Aug 15, 2022

Uh oh!

OmkarPh commented Sep 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pombredanne Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

OmkarPh Dec 3, 2022

Choose a reason for hiding this comment

Uh oh!

AyanSinhaMahapatra Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

OmkarPh Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

AyanSinhaMahapatra Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

mjherzog Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

OmkarPh Feb 15, 2023

Choose a reason for hiding this comment

Uh oh!

martin-langhoff commented Dec 1, 2022

Uh oh!

martin-langhoff commented Dec 1, 2022

Uh oh!

OmkarPh commented Dec 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OmkarPh commented Jan 6, 2023

Uh oh!

AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OmkarPh commented Sep 17, 2022 •

edited

Loading

OmkarPh commented Dec 3, 2022 •

edited

Loading