Merged
Conversation
Owner
|
Hi @afzaalb this is great! I have one requests though: make sure the import path is short, so it should be |
Author
|
Icons can now be imported as |
Kilian
reviewed
Dec 18, 2018
Owner
|
I will make a new release in the next few days, Thanks again @afzaalb! |
Author
|
Thank You ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added all the icons as individual components and they can now be imported as
import ArrowLeft from 'react-bytesize-icons/lib/components/ArrowLeft'.We can still import icons as we used to do previously, but the reason for doing this is when i'm only using 10 icons from a set of 94 icons my JS bundle increases significantly.
The icons bundle is almost 52K.Technically i should be importing those specific icons so i import few kb's from icon-bundle instead of whole 52K.
Hope my explanation is clear.
You can see the difference with both approaches in screenshot attached.