Skip to content

Fix a few lingering problems#6

Merged
abbccdda merged 3 commits into
abbccdda:find_coordinator_forwarding-KAFKA-9751from
hachikuji:KAFKA-9751
Feb 6, 2021
Merged

Fix a few lingering problems#6
abbccdda merged 3 commits into
abbccdda:find_coordinator_forwarding-KAFKA-9751from
hachikuji:KAFKA-9751

Conversation

@hachikuji

@hachikuji hachikuji commented Feb 5, 2021

Copy link
Copy Markdown
  • Non-existing partitions missing from response when auto creation not enabled in the request
  • Check and act is not safe when inserting into inflight map
  • Change value type of inflight map to Boolean since we don't need the value
  • Set timeout of 0 in the call to ZkAdminManager.createTopics since we don't need to wait for full creation
  • Fix log message which suggests that creation through ZkAdminManager is asynchronous
  • Clean up error message when the number of live brokers is insufficient for the replication factor
  • Reuse value of MetadataCache.aliveBrokers rather than recomputing for every partition
  • Controller mutation quota was not setting version correctly. Fixed to use permissive quota which is consistent with current behavior

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@abbccdda abbccdda force-pushed the find_coordinator_forwarding-KAFKA-9751 branch 2 times, most recently from 85ea897 to c68c7d0 Compare February 6, 2021 00:32
@abbccdda abbccdda merged commit 7e745da into abbccdda:find_coordinator_forwarding-KAFKA-9751 Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants