fixing the compose file and Dockerfile fixes #23#25
Merged
ryaben17 merged 1 commit intoaau-network-security:CYBERfrom Apr 1, 2021
ABresting:CYBER
Merged
fixing the compose file and Dockerfile fixes #23#25ryaben17 merged 1 commit intoaau-network-security:CYBERfrom ABresting:CYBER
ryaben17 merged 1 commit intoaau-network-security:CYBERfrom
ABresting:CYBER
Conversation
Collaborator
Author
|
fixes #23 |
Collaborator
|
Hi @ABresting! Sorry for the late answer :) Thank you very much for the PR though, any help is more than welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR consists of the fixes due to which the docker-compose command was failing. Mostly they were errors or omissions:
Alongside added and mounted "logger" directory which helps collect logs in a general way, works well for *nix based OS for now.