-- TODO: fix ssh. Highligthed the lines that crashes the plugin

ryaben17 · ryaben17 · commit aee76f619cff · 2021-04-17T11:54:12.000+02:00
diff --git a/pkg/plugin/sshd/sshd.go b/pkg/plugin/sshd/sshd.go
@@ -135,7 +135,11 @@ func (s *SSH) handleChannels(sshItem SSHConn, chans <-chan ssh.NewChannel) {
 			s.Running <- false
 			return
 		case conn := <-chans:
+			//TODO: this line crashes the app when the connection is lost!!!
+			// Fix it ASAP!
+			// ☟ ☟ ☟
 			go s.handleChannel(sshItem, conn)
+			// ☝ ☝ ☝
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,11 @@ func (s *SSH) handleChannels(sshItem SSHConn, chans <-chan ssh.NewChannel) {`
`135`	`135`	`s.Running <- false`
`136`	`136`	`return`
`137`	`137`	`case conn := <-chans:`
	`138`	`+ //TODO: this line crashes the app when the connection is lost!!!`
	`139`	`+ // Fix it ASAP!`
	`140`	`+ // ☟ ☟ ☟`
`138`	`141`	`go s.handleChannel(sshItem, conn)`
	`142`	`+ // ☝ ☝ ☝`
`139`	`143`	`}`
`140`	`144`	`}`
`141`	`145`	`}`