QuoteWrap columns in many-to-many eager join#1094
Merged
stephenafamo merged 2 commits intoaarondl:masterfrom Feb 20, 2022
Merged
QuoteWrap columns in many-to-many eager join#1094stephenafamo merged 2 commits intoaarondl:masterfrom
stephenafamo merged 2 commits intoaarondl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle condition where the to-many select statement was not wrapping columns in quotes. I followed the pattern established by
templates/main/01_types.go.tpl, so I have a high level of confidence this is the right solution.I also added a new Enum and Table to the
testdata/psql_test_schema.sqlfile so we can catch errors like this in the future.