Add melange version of Promise (promise.js)#80
Open
davesnx wants to merge 5 commits intoaantron:masterfrom
Open
Add melange version of Promise (promise.js)#80davesnx wants to merge 5 commits intoaantron:masterfrom
davesnx wants to merge 5 commits intoaantron:masterfrom
Conversation
davesnx
commented
Oct 4, 2023
| [@ocaml.warning "-33"] | ||
| test("resolved: Almost-Promise-like", () => { | ||
| let open Js_OO; | ||
| /* let open Js_OO; */ |
Author
There was a problem hiding this comment.
I commented this out since didn't seem needed, but wanted to acknowledge that I have no clue what's Js_OO
davesnx
commented
Oct 4, 2023
| @@ -0,0 +1,3 @@ | |||
| (library | |||
Author
There was a problem hiding this comment.
ffi is a lib under test now, with the 2 separate versions
davesnx
commented
Oct 4, 2023
| @@ -1,3 +1,3 @@ | |||
| (library | |||
Author
There was a problem hiding this comment.
The run file/lib isn't needed anymore since we can share framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
This PR is a first attempt to migrate the promise version of previously builded from BuckleScript to Melange (and all of the related constraints).
I believe the change it's on a good direction since Melange enables sharing code and the original idea of this project seems to share the same interface between native and JS. If we want to keep the BuckleScript/ReScript version I could do a similar trick done in styled-ppx davesnx/styled-ppx#353
I vendor promise under server-reason-react here: https://github.com/ml-in-barcelona/server-reason-react/tree/main/packages/promise in order to enjoy the same experience as this library will provide (eventually will remove the vendor lib).
What are the changes:
[@bs.val](Melange don't need those)bs.*intomel.*modes melange(wrapped false)undertest/to avoid changing the source-code.What hasn't been done:
Status
The proposition for this is to gather feedback about the changes and eventually release this as a new opam version.
Current test can be ran with: