Skip to content

fix: remove closed issues #337 and #226 from ROADMAP and limitation tables#437

Merged
aallan merged 2 commits into
mainfrom
fix/roadmap-history-consistency
Mar 30, 2026
Merged

fix: remove closed issues #337 and #226 from ROADMAP and limitation tables#437
aallan merged 2 commits into
mainfrom
fix/roadmap-history-consistency

Conversation

@aallan

@aallan aallan commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Remove #337 (JS coverage) from ROADMAP Phase 3c — shipped in v0.0.96; add one-liner to HISTORY.md v0.0.96 row
  • Remove #226 (typed holes) from KNOWN_ISSUES.md and vera/README.md limitations table — shipped in v0.0.105

Summary by CodeRabbit

  • Documentation
    • Updated release notes to document native JavaScript browser-runtime coverage improvements and aligned browser test coverage visibility.
    • Removed the “typed holes for partial programmes” limitation from known issues and README.
    • Clarified effect-row polymorphism wording in the user guide.
    • Updated spec text to reflect that String memory is managed by a conservative mark–sweep garbage collector.

@aallan
fix: remove closed issues #337 and #226 from ROADMAP and limitation t…
469fc30 
…ables

- #337 (JS coverage): delete from ROADMAP Phase 3c, add to HISTORY v0.0.96 row
- #226 (typed holes): delete from KNOWN_ISSUES.md and vera/README.md limitations table (shipped in v0.0.105)

Co-Authored-By: Claude <noreply@anthropic.invalid>
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 21efc713-a09d-4ef8-8edc-020942827104

📥 Commits

Reviewing files that changed from the base of the PR and between 469fc30 and ecfea25.

📒 Files selected for processing (3)
  • ROADMAP.md
  • spec/04-expressions.md
  • vera/README.md
💤 Files with no reviewable changes (1)
  • ROADMAP.md
📝 Walkthrough

Walkthrough

Updated documentation and spec text: HISTORY.md notes native JavaScript browser-runtime coverage for v0.0.96; ROADMAP.md removed the Milestone 3c (native JS coverage) and Milestone 4a (true async concurrency); KNOWN_ISSUES.md and vera/README.md removed the “No typed holes” limitation; spec text for String memory now documents a conservative mark‑sweep GC (shipped v0.0.65).

Changes

Cohort / File(s) Summary
Release & tracking docs
HISTORY.md, ROADMAP.md, KNOWN_ISSUES.md		 HISTORY: added v0.0.96 entry describing native JS browser-runtime coverage (NODE_V8_COVERAGE + c8 + Codecov). ROADMAP: removed Milestone 3c (#337) and Milestone 4a (#59). KNOWN_ISSUES: removed “Typed holes for partial programs” row (#226).
Compiler docs
vera/README.md		 Updated wording on effect-row polymorphism (clarified full bidirectional type checking not yet implemented); removed “No typed holes” from Current Limitations table.
Language spec
spec/04-expressions.md		 Changed runtime description for String memory to state it is managed by a conservative mark‑sweep garbage collector (references issue #51 and notes collector shipped in v0.0.65).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

compiler, spec, docs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing closed issues #337 and #226 from ROADMAP and limitation tables, which aligns with the primary objectives of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/roadmap-history-consistency

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (0c3a2e1) to head (ecfea25).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files          49       49           
  Lines       19278    19278           
  Branches      220      220           
=======================================
  Hits        17410    17410           
  Misses       1864     1864           
  Partials        4        4
Flag Coverage Δ
javascript 50.56% <ø> (ø)
python 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aallan
fix: remove stale references to closed issues #51, #55, #59 in docs
ecfea25 
- spec/04-expressions.md: update string memory note — GC shipped v0.0.65 (#51)
- vera/README.md: drop closed #55 reference from effect row prose
- ROADMAP.md: remove #59 (true async) — closed; remaining work tracked under #406 (WASI 0.3)

Co-Authored-By: Claude <noreply@anthropic.invalid>
@aallan aallan merged commit d80d612 into main Mar 30, 2026
19 checks passed
@aallan aallan deleted the fix/roadmap-history-consistency branch March 30, 2026 16:11
This was referenced Apr 16, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aallan