Make parse_nat return Result<Nat, String> per spec (#174)#191
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_natnow returnsResult<Nat, String>instead of bareNat, matching the spec (Section 9). ReturnsOk(n)on valid decimal input,Err("empty string")on empty/whitespace-only input, andErr("invalid digit")on non-numeric characters.Ok/Err/Some/Noneworks without a userdatadeclaration._extract_constructor_fieldsnow handles String (pair type) bindings inside ADT constructors, enablingErr(@String)match arms.Test plan
vera run examples/string_ops.veraproduces correct outputtest_roundtripandtest_strip_then_parseto match on ResultCloses #174
Generated with Claude Code