Implement nested constructor pattern codegen (#131)#186
Merged
Conversation
Match expressions with nested constructor patterns (e.g. Cons(Some(@int), _)) now compile to WASM correctly. Previously any ConstructorPattern or NullaryPattern sub-pattern caused the function to be silently skipped (return None at L347). Changes to vera/wasm/data.py: - _collect_nested_tag_checks: recursively emits tag comparisons for nested constructors, AND-chained into the arm condition - _extract_constructor_fields: recursively loads nested field pointers and binds their sub-patterns (ConstructorPattern), or advances offset for nullary (NullaryPattern) - _sub_pattern_wasm_type: resolves WASM types for offset computation - _translate_match_condition: integrates nested checks after outermost tag check 5 new tests, 1,337 total. examples/pattern_matching.vera first_some now compiles and runs. Co-Authored-By: Claude <noreply@anthropic.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #131