Switch from deprecated X.min(i) to i = X.index_min() (and max())#40
Merged
aalfons merged 1 commit intoaalfons:mainfrom Sep 29, 2025
Merged
Switch from deprecated X.min(i) to i = X.index_min() (and max())#40aalfons merged 1 commit intoaalfons:mainfrom
aalfons merged 1 commit intoaalfons:mainfrom
Conversation
31 tasks
Owner
|
Thanks for submitting the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Armadillo 15.0.* now makes C++14 the minimum compilation standard, which also means I can no-longer add the suppression of deprecation warnings (which used a macro before and now use a C++14 or later attribute). For most packages, adapting to it can be very simple, and yours is one of them -- in fact it is just a five statements in two files, all about
X.min(index)andX.max(index)now preferred asindex = X.min_index()(andX.max_index(). In the patch below we simply update this as now required by Armadillo 15.0.x. (I also commented one#includeout as I got spurious warnings. We get the R headers by relying on theRcppArmadillo.hinclude and that is usually more robust.)Please see issues #475 and below at the RcppArmadillo GitHub repo for context, and notably #491 for this second wave of PRs and patches (following one for moving away from C++11, something your package does not need). It would be terrific if you could make an upload to CRAN 'soon' to remove the deprecation warning. Please do not hesitate to reach out if I can assist in any way or clarify matters.