Remove redundant codex transport patch (upstream via NousResearch/hermes-agent#33409)#20
Merged
Merged
Conversation
The Hermes codex transport patch in this Dockerfile moves `tools` into the `if response_tools:` block so tool-less Codex calls don't send an empty `tools` field. That exact change shipped upstream in NousResearch/hermes-agent#33409, which is part of v0.15.0 (2026.5.28) and therefore already present in `nousresearch/hermes-agent:latest`. The patch's `if 'kwargs["tools"] = response_tools' in s:` early-return was already making this RUN block a no-op at build time; this PR drops the dead code. The other two patches (openai SDK null-guard, mnemosyne lazy-register) are kept: - openai SDK null-guard: upstream fix PR #34544 merged today (May 29) but did NOT land in v0.15.2 — keep until v0.15.3. - mnemosyne lazy-register: separate concern, not yet superseded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the third
RUNblock inDockerfilethat patched/opt/hermes/agent/transports/codex.pyto movekwargs["tools"]into theif response_tools:branch.Why
The exact same change is already upstream:
toolskey when no tools registered"nousresearch/hermes-agent:latest— which is our base image.if 'kwargs["tools"] = response_tools' in s: print("already present")guard was already making the RUN block a no-op at build time. This PR just removes the dead code.What's kept
The other two patches in the Dockerfile remain:
_parsing/_responses.py)mainbut NOT in v0.15.2local_llm.py)Test
🤖 Generated with Claude Code