apps/web/src/routes/_chat.settings.tsx (1)

214-246: ⚠️ Potential issue | 🟠 Major

Update workflow is still unreachable from Settings UI.

Lines 214-246 add update state and handlers, but no rendered control invokes them (About currently only shows APP_VERSION). This leaves the “Check for Updates / Download / Restart & Install / Retry + progress” objective unfulfilled.

As per coding guidelines, **/*.{js,ts,tsx,jsx}: “All of bun fmt, bun lint, and bun typecheck must pass before considering tasks completed.”

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/routes/_chat.settings.tsx` around lines 214 - 246, The new
update state and handlers (updateState, isCheckingUpdate, handleCheckForUpdate,
handleDownloadUpdate, handleInstallUpdate) are wired but never rendered; add UI
controls in the Settings/About render so users can trigger the flow and see
progress: render the APP_VERSION plus conditional buttons and status text that
call handleCheckForUpdate, handleDownloadUpdate and handleInstallUpdate based on
updateState (e.g., show "Check for Updates" when idle, show "Download" when an
update is available, show "Install/Restart" when downloaded, show progress and a
"Retry" on errors) and disable buttons when isCheckingUpdate is true; ensure the
UI updates reflect updateState fields and errors so the full “Check / Download /
Install / Retry + progress” workflow is reachable and test passes.

apps/web/src/routes/_chat.settings.tsx (1)

217-246: ⚠️ Potential issue | 🟡 Minor

Catch bridge call failures to avoid uncaught async errors.

getUpdateState, checkForUpdate, downloadUpdate, and installUpdate still reject without local catch handling, so IPC failures can bubble as uncaught promise rejections and leave the UI without clear fallback state.

Proposed hardening

   useEffect(() => {
     if (!isElectron || !window.desktopBridge) return;
     const bridge = window.desktopBridge;
-    void bridge.getUpdateState().then(setUpdateState);
+    void bridge
+      .getUpdateState()
+      .then(setUpdateState)
+      .catch((error) => {
+        console.error("Failed to read update state", error);
+        setUpdateState((prev) =>
+          prev
+            ? {
+                ...prev,
+                status: "error",
+                message: "Failed to read update state.",
+                errorContext: "check",
+                canRetry: true,
+              }
+            : prev,
+        );
+      });
     const unsubscribe = bridge.onUpdateState(setUpdateState);
     return unsubscribe;
   }, []);

   const handleCheckForUpdate = useCallback(async () => {
     if (!isElectron || !window.desktopBridge) return;
     setIsCheckingUpdate(true);
     try {
       const state = await window.desktopBridge.checkForUpdate();
       setUpdateState(state);
+    } catch (error) {
+      console.error("Failed to check for updates", error);
+      setUpdateState((prev) =>
+        prev
+          ? {
+              ...prev,
+              status: "error",
+              message: error instanceof Error ? error.message : "Failed to check for updates.",
+              errorContext: "check",
+              canRetry: true,
+            }
+          : prev,
+      );
     } finally {
       setIsCheckingUpdate(false);
     }
   }, []);

   const handleDownloadUpdate = useCallback(async () => {
     if (!isElectron || !window.desktopBridge) return;
-    const result = await window.desktopBridge.downloadUpdate();
-    setUpdateState(result.state);
+    try {
+      const result = await window.desktopBridge.downloadUpdate();
+      setUpdateState(result.state);
+    } catch (error) {
+      console.error("Failed to download update", error);
+      setUpdateState((prev) =>
+        prev
+          ? {
+              ...prev,
+              status: "error",
+              message: error instanceof Error ? error.message : "Failed to download update.",
+              errorContext: "download",
+              canRetry: true,
+            }
+          : prev,
+      );
+    }
   }, []);

   const handleInstallUpdate = useCallback(async () => {
     if (!isElectron || !window.desktopBridge) return;
-    const result = await window.desktopBridge.installUpdate();
-    setUpdateState(result.state);
+    try {
+      const result = await window.desktopBridge.installUpdate();
+      setUpdateState(result.state);
+    } catch (error) {
+      console.error("Failed to install update", error);
+      setUpdateState((prev) =>
+        prev
+          ? {
+              ...prev,
+              status: "error",
+              message: error instanceof Error ? error.message : "Failed to install update.",
+              errorContext: "install",
+              canRetry: true,
+            }
+          : prev,
+      );
+    }
   }, []);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/routes/_chat.settings.tsx` around lines 217 - 246, The bridge
IPC calls can reject and must be locally handled: wrap the initial
bridge.getUpdateState call in the useEffect and each async handler
(handleCheckForUpdate, handleDownloadUpdate, handleInstallUpdate, and the
bridge.downloadUpdate/bridge.installUpdate invocations) in try/catch blocks,
logging the error (or calling a UI error handler) and optionally setting a safe
fallback update state so failures don’t produce uncaught promise rejections or
leave the UI in an indeterminate state; preserve the existing finally that
clears isCheckingUpdate in handleCheckForUpdate.

apps/web/src/routes/_chat.settings.tsx (1)

217-246: ⚠️ Potential issue | 🟡 Minor

Handle rejected desktop bridge promises to avoid unhandled async errors.

This is still open from prior feedback: Line 220 and Lines 238-245 can reject without a catch, and handleCheckForUpdate (Line 225-234) rethrows on failure. In click handlers, that becomes an unhandled rejection with no user-facing fallback.

#!/bin/bash
# Verify bridge calls that can reject without explicit catch handling
rg -nP 'getUpdateState\(\)\.then\(setUpdateState\)(?!\s*\.catch)' apps/web/src/routes/_chat.settings.tsx -n -C2
rg -nP 'await window\.desktopBridge\.(checkForUpdate|downloadUpdate|installUpdate)\(' apps/web/src/routes/_chat.settings.tsx -n -C2

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/routes/_chat.settings.tsx` around lines 217 - 246, In useEffect
and the three handlers (handleCheckForUpdate, handleDownloadUpdate,
handleInstallUpdate) guard against rejected desktop bridge promises by adding
explicit error handling: for the useEffect promise from
window.desktopBridge.getUpdateState() chain a .catch that logs the error (and
does not leave an unhandled rejection) and ensure the unsubscribe from
bridge.onUpdateState remains returned; for each click handler wrap await calls
to window.desktopBridge.checkForUpdate(), downloadUpdate(), and installUpdate()
in try/catch blocks (handleCheckForUpdate already sets isCheckingUpdate—ensure
errors are caught and setIsCheckingUpdate(false) in finally without rethrowing)
and call setUpdateState only on success, logging or surfacing errors (e.g., via
console.error or a UI notification) instead of allowing unhandled rejections.