Fix CodeRabbit review issues from PR #6

aaditagrawal · aaditagrawal · commit c53f5e3bfa3d · 2026-03-11T02:04:02.000+05:30
- Add response.ok check in fetchLatestRelease to handle API errors
- Move isUnknownPendingApprovalRequestError check before failure append
- Remove unused Array import from ProviderHealth.ts
- Default hasOriginRemote to true while loading in GitActionsControl
diff --git a/apps/marketing/src/lib/releases.ts b/apps/marketing/src/lib/releases.ts
@@ -20,7 +20,11 @@ export async function fetchLatestRelease(): Promise<Release> {
   const cached = sessionStorage.getItem(CACHE_KEY);
   if (cached) return JSON.parse(cached);
 
-  const data = await fetch(API_URL).then((r) => r.json());
+  const response = await fetch(API_URL);
+  if (!response.ok) {
+    throw new Error(`Failed to fetch latest release (${response.status})`);
+  }
+  const data = (await response.json()) as Release;
 
   if (data?.assets) {
     sessionStorage.setItem(CACHE_KEY, JSON.stringify(data));
diff --git a/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts b/apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
@@ -561,6 +561,7 @@ const make = Effect.gen(function* () {
             if (Cause.hasInterruptsOnly(cause)) {
               return yield* Effect.failCause(cause);
             }
+            if (isUnknownPendingApprovalRequestError(cause)) return;
             yield* appendProviderFailureActivity({
               threadId: event.payload.threadId,
               kind: "provider.approval.respond.failed",
@@ -570,8 +571,6 @@ const make = Effect.gen(function* () {
               createdAt: event.payload.createdAt,
               requestId: event.payload.requestId,
             });
-
-            if (!isUnknownPendingApprovalRequestError(cause)) return;
           }),
         ),
       );
diff --git a/apps/server/src/provider/Layers/ProviderHealth.ts b/apps/server/src/provider/Layers/ProviderHealth.ts
@@ -17,7 +17,7 @@ import type {
   ServerProviderStatusState,
 } from "@t3tools/contracts";
 import { CopilotClient, type ModelInfo } from "@github/copilot-sdk";
-import { Array, Effect, Fiber, FileSystem, Layer, Option, Path, Result, Stream } from "effect";
+import { Effect, Fiber, FileSystem, Layer, Option, Path, Result, Stream } from "effect";
 import { ChildProcess, ChildProcessSpawner } from "effect/unstable/process";
 
 import { resolveBundledCopilotCliPath, withSanitizedCopilotDesktopEnv } from "./copilotCliPath.ts";
diff --git a/apps/web/src/components/GitActionsControl.tsx b/apps/web/src/components/GitActionsControl.tsx
@@ -173,7 +173,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
   const { data: branchList = null } = useQuery(gitBranchesQueryOptions(gitCwd));
   // Default to true while loading so we don't flash init controls.
   const isRepo = branchList?.isRepo ?? true;
-  const hasOriginRemote = branchList?.hasOriginRemote ?? false;
+  const hasOriginRemote = branchList?.hasOriginRemote ?? true;
   const currentBranch = branchList?.branches.find((branch) => branch.current)?.name ?? null;
   const isGitStatusOutOfSync =
     !!gitStatus?.branch && !!currentBranch && gitStatus.branch !== currentBranch;
