fix: pin starlette dependency to >=1.1.0#184
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the dependency constraint for Starlette to >=1.1.0 in both the template and generated pyproject.toml files. However, as pointed out in the review, Starlette's current versioning is in the 0.x.y range, meaning a 1.1.0 release does not exist on PyPI and will cause dependency resolution to fail. It is recommended to adjust the constraint to a valid version, such as >=0.40.0.
| "a2a-sdk[http-server,grpc,sqlite]>={{ a2a_python_sdk_version }}", | ||
| "packaging", | ||
| "starlette", | ||
| "starlette>=1.1.0", |
There was a problem hiding this comment.
Starlette does not have a 1.1.0 release on PyPI; its versioning is currently in the 0.x.y range (e.g., 0.45.x). Pinning to >=1.1.0 will cause dependency resolution to fail. If the intention was to pin to a recent version, use a valid 0.x.y version such as >=0.40.0.
"starlette>=0.40.0",
There was a problem hiding this comment.
@gemini-code-assist. You're wrong: https://pypi.org/project/starlette/1.1.0.
Next time you review dependencies, please check pypi.org to ensure you have the latest information available.
There was a problem hiding this comment.
You are absolutely right, and I apologize for the error. My information regarding Starlette's versioning was outdated. Thank you for the correction and for pointing me to the current PyPI release.
Summary
starlettedependency to>=1.1.0in both the codegen template and the generated Python SUTpyproject.tomlTest plan
uv syncresolves successfully with starlette 1.1.0🤖 Generated with Claude Code