Skip to content

refactor: rename HTTP REST to REST#247

Merged
ishymko merged 4 commits into
mainfrom
ishymko/http-rest-renaming
Dec 10, 2025
Merged

refactor: rename HTTP REST to REST#247
ishymko merged 4 commits into
mainfrom
ishymko/http-rest-renaming

Conversation

@ishymko

@ishymko ishymko commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Follow-up for unreleased #142.

The spec uses HTTP+JSON/REST wording and other SDKs use just REST in all names (i.e. Python and Golang).

@gemini-code-assist

gemini-code-assist Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the codebase by renaming components related to the HTTP+REST protocol binding. The primary goal is to align the naming conventions with the A2A protocol specification and other SDKs, simplifying http_rest to just rest for better consistency and readability throughout the project.

Highlights

  • File Renaming: The http_rest_handler.ts file has been renamed to rest_handler.ts in both src/server/express/ and src/server/transports/rest/ directories to align with the new naming convention.
  • Identifier Renaming: The HttpRestHandlerOptions interface and the httpRestHandler function have been renamed to RestHandlerOptions and restHandler respectively, for improved clarity and consistency with the A2A protocol specification.
  • Codebase Updates: All relevant import and export statements, as well as function calls and test suite descriptions, have been updated across the codebase to reflect the new rest naming convention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@ishymko ishymko marked this pull request as ready for review December 10, 2025 10:27
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 10, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good refactoring that renames http_rest to rest for consistency with the specification and other SDKs. The changes are mostly correct and applied consistently across the codebase. I've found a couple of issues to address to complete the refactoring: an outdated comment and a test file that should be renamed. Please see my detailed comments.

Comment thread test/server/rest_handler.spec.ts
Comment thread src/server/express/rest_handler.ts
@ishymko ishymko changed the title refactor: rename http_rest to rest refactor: rename HTTP REST to REST Dec 10, 2025
@ishymko ishymko enabled auto-merge (squash) December 10, 2025 10:32
@ishymko ishymko merged commit 919cbaa into main Dec 10, 2025
6 checks passed
@ishymko ishymko deleted the ishymko/http-rest-renaming branch December 10, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guglielmo-san guglielmo-san guglielmo-san approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ishymko @guglielmo-san