Skip to content

ci: use esbuild to ensure client and root entry points build for browser#210

Merged
ishymko merged 4 commits intomainfrom
ishymko/browser-build-test
Nov 27, 2025
Merged

ci: use esbuild to ensure client and root entry points build for browser#210
ishymko merged 4 commits intomainfrom
ishymko/browser-build-test

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Nov 27, 2025

Description

Add an automated test for the issue solved previously in #46 to ensure that client and root entry points build for browsers.

Example failure would look like:

✘ [ERROR] Could not resolve "events"

    dist/server/index.js:27:29:
      27 │ import { EventEmitter } from "events";
         ╵                              ~~~~~~~~

  The package "events" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "--platform=node" to do that, which will remove this error.

(obtained by running esbuild ./dist/server/index.js --bundle --platform=browser --outdir=dist/tmp-checks --outbase=./dist)

@ishymko ishymko force-pushed the ishymko/browser-build-test branch 6 times, most recently from 8c66af5 to 82b6c6a Compare November 27, 2025 12:09
@ishymko ishymko force-pushed the ishymko/browser-build-test branch from 82b6c6a to 660296c Compare November 27, 2025 12:11
@ishymko ishymko marked this pull request as ready for review November 27, 2025 12:14
@ishymko ishymko enabled auto-merge (squash) November 27, 2025 15:35
@ishymko ishymko merged commit 86f6cfa into main Nov 27, 2025
6 checks passed
@ishymko ishymko deleted the ishymko/browser-build-test branch November 27, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants