ci: integrate prettier check in github workflow#185
Conversation
feat: Implement linter and prettier
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and consistency by integrating Prettier for automated code formatting. It also updates the ESLint configuration to work seamlessly with Prettier, ensuring a standardized and maintainable codebase. The changes aim to automate code formatting, reduce manual formatting efforts, and improve overall code aesthetics. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request sets up Prettier for code formatting and applies it across the codebase, which is a great step for consistency. The configuration and formatting changes look good.
However, the primary goal of this PR, as stated in the title and description, is to 'integrate prettier check in github workflow'. This change appears to be missing, as no GitHub workflow files have been added or modified. Without this, the Prettier check will not run as part of your CI pipeline. This is a critical omission.
I recommend adding a new workflow file, for example .github/workflows/lint.yml, with a job to run the formatter check.
Additionally, to make it easier for developers to use Prettier locally, I suggest adding dedicated scripts to your package.json for checking and applying formatting. For example:
"scripts": {
...
"format": "prettier --write .",
"format:check": "prettier --check ."
}Please add the GitHub workflow file to complete this PR's stated goal.
Co-authored-by: Ivan Shymko <vana.shimko@gmail.com>
Description
This PR integrates the prettier check in the github workflow to ensure the code respects the correct formatting standards
Fixes #177 🦕