Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kthota-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new feature that provides greater flexibility for A2A agent deployments by allowing the specification of a custom path for the agent card. Previously, the client strictly expected the agent card at a fixed .well-known location. This change enables agents to host their agent.json file at any desired URL. Additionally, minor improvements to error handling in RPC and SSE communications have been included for better diagnostic information.
Highlights
- Custom Agent Card URL Support: The
A2AClientconstructor and thegetAgentCardmethod now accept an optionalagentCardPathparameter, allowing users to specify a custom location for theagent.jsonfile instead of the default.well-known/agent.json. - Default Agent Card Path Constant: A new static constant,
A2AClient.DEFAULT_AGENT_CARD_PATH, has been introduced to explicitly define the standard.well-known/agent.jsonpath, improving clarity and maintainability. - Improved Error Logging: Error messages generated during RPC calls and SSE event processing have been made more robust by ensuring that
error.datais stringified as an empty object ({}) if it'sundefinedornull, preventing potentialJSON.stringifyerrors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature allowing a custom path for the agent card, which was previously hardcoded. The changes are well-implemented, adding flexibility to the client. My review includes suggestions to improve documentation clarity, code maintainability by addressing duplicated logic, and prevent potential errors by providing default values for potentially undefined data fields in error messages.
🤖 I have created a release *beep* *boop* --- ## [0.2.5](v0.2.4...v0.2.5) (2025-07-30) ### Features * add support for custom agent card url. resolves [#68](#68) ([#79](#79)) ([dc92d32](dc92d32)) * Export ExecutionEventQueue in server ([#61](#61)) ([530c0b9](530c0b9)) * Export type AgentExecutionEvent ([#66](#66)) ([f4c81f4](f4c81f4)) ### Bug Fixes * correct the example code ([#64](#64)) ([126eee4](126eee4)) * setting context id in _createRequestContext ([#49](#49)) ([1abc8a1](1abc8a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #68 🦕