Skip to content

fix: setting context id in _createRequestContext#49

Merged
swapydapy merged 9 commits into
a2aproject:mainfrom
clriesco:main
Jul 30, 2025
Merged

fix: setting context id in _createRequestContext#49
swapydapy merged 9 commits into
a2aproject:mainfrom
clriesco:main

Conversation

@clriesco

@clriesco clriesco commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #41 🦕

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 10, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @clriesco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the DefaultRequestHandler that prevented the contextId from being consistently and correctly set when creating a new request context. The fix ensures that the contextId is properly derived and assigned based on available sources, resolving issue #41.

Highlights

  • Bug Fix: Resolved an issue where the contextId was not being correctly propagated or set when creating a new RequestContext within the DefaultRequestHandler.
  • Context ID Logic: Reworked the logic for determining the contextId to ensure it correctly prioritizes an existing contextId from the incomingMessage, falls back to task?.contextId, and generates a new UUID only if neither is present.
  • Code Simplification: Streamlined the contextId assignment, removing redundant variable declarations and ensuring the final contextId is correctly applied to the messageForContext object.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 10, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in how the contextId is determined when creating a RequestContext, ensuring that an existing task's context ID is correctly reused. The logic is now cleaner and correct. My main feedback is to add a dedicated test case to cover this fix and prevent future regressions.

Comment thread src/server/request_handler/default_request_handler.ts
@swapydapy

swapydapy commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

Thanks for the fix. Could you also add a testcase here at to catch this regression in future.
https://github.com/a2aproject/a2a-js/blob/main/test/server/default_request_handler.spec.ts

@clriesco

clriesco commented Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Tests added :)

swapydapy
swapydapy requested changes Jul 14, 2025
View reviewed changes
Comment thread test/server/default_request_handler.spec.ts Outdated
Comment thread test/server/default_request_handler.spec.ts Outdated
swapydapy
swapydapy requested changes Jul 17, 2025
View reviewed changes
Comment thread test/server/default_request_handler.spec.ts Outdated
Comment thread test/server/default_request_handler.spec.ts Outdated
@swapydapy

swapydapy commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

The code changes look fine. I think, the commits from PR #61, also got merged here.

Could you submit that PR first.

@clriesco
Revert "fixed tests"
e7b00c2 
This reverts commit 412d3ce.
@clriesco

clriesco commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

yes, got a mess in git. Now the branch is reseted and rebased.

@swapydapy

swapydapy commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Thanks. Need to resolve some conflicts.

@swapydapy swapydapy mentioned this pull request Jul 29, 2025
Closed
@clriesco clriesco requested a review from swapydapy July 29, 2025 13:15
@swapydapy swapydapy merged commit 1abc8a1 into a2aproject:main Jul 30, 2025
1 check passed
@release-please release-please Bot mentioned this pull request Jul 29, 2025
Merged
swapydapy pushed a commit that referenced this pull request Jul 30, 2025
@release-please
chore(main): release 0.2.5 (#67)
305dbef 
🤖 I have created a release *beep* *boop*
---


## [0.2.5](v0.2.4...v0.2.5)
(2025-07-30)


### Features

* add support for custom agent card url. resolves
[#68](#68)
([#79](#79))
([dc92d32](dc92d32))
* Export ExecutionEventQueue in server
([#61](#61))
([530c0b9](530c0b9))
* Export type AgentExecutionEvent
([#66](#66))
([f4c81f4](f4c81f4))


### Bug Fixes

* correct the example code
([#64](#64))
([126eee4](126eee4))
* setting context id in _createRequestContext
([#49](#49))
([1abc8a1](1abc8a1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@swapydapy swapydapy mentioned this pull request Jul 31, 2025
Closed
4 tasks
@bartek-gralewicz bartek-gralewicz mentioned this pull request Apr 30, 2026
Closed
@a2a-bot a2a-bot mentioned this pull request May 4, 2026
Merged
@a2a-bot a2a-bot mentioned this pull request May 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swapydapy swapydapy swapydapy approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Question]: Why _createRequestContext sets different context IDs for task and incoming message?

2 participants

@clriesco @swapydapy