feat: implement gRPC client#299
Conversation
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the client's communication capabilities by integrating gRPC as a supported transport protocol. It provides the necessary infrastructure for gRPC-based interactions, including new transport classes, factory integration, and error handling, ensuring a more versatile and performant client. The changes are thoroughly tested with both unit and end-to-end scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…ion by removing redundant `|| undefined`.
There was a problem hiding this comment.
Code Review
This pull request introduces a gRPC transport for the client-side, which is a great feature. The implementation is well-structured, with a dedicated GrpcTransport class and a corresponding factory. The use of helper methods to wrap unary and streaming gRPC calls is a good pattern that keeps the public methods clean and consistent. The error mapping from gRPC statuses to application-specific errors is also a nice touch for better error handling on the client side. I've added a few comments, including a critical one about a potential runtime error in getExtendedAgentCard due to an incorrect parser, and some medium-severity suggestions to improve type safety and code consistency. The addition of unit tests for the new transport and the extension of E2E tests to cover gRPC are excellent and ensure the new functionality is well-tested.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
🧪 Code Coverage
Generated by coverage-comment.yml |
Co-authored-by: Ivan Shymko <vana.shimko@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.9](v0.3.8...v0.3.9) (2026-01-21) ### Features * implement gRPC client ([#299](#299)) ([dbdb96e](dbdb96e)) * implement gRPC server ([#279](#279)) ([bd4caa2](bd4caa2)) ### Bug Fixes * use proto default values in generated a2a_types.ts ([#303](#303)) ([0215d42](0215d42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
This PR extends the implementation of grpc to Client.
A new index.js is created to export the grpc specific functions, preventing the need for every client to install the
grpc/jspackageRelease-As: 0.3.9
Fixes #275 🦕