fix: enable follow up task issue on non blocking request by guglielmo-san · Pull Request #160 · a2aproject/a2a-js

guglielmo-san · 2025-10-30T14:49:58Z

Description

This PR ensure that when a follow up task is sent to a task in a non final state using the NON blocking mode, the _processEvents will return the first available Message/Task status published on the bus, and will not throw an error.
Follows the implementation of Python SDK

This PR will make this tck-test pass.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
- Important Prefixes for release-please:
  - fix: which represents bug fixes, and correlates to a SemVer patch.
  - feat: represents a new feature, and correlates to a SemVer minor.
  - feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
Ensure the tests and linter pass
Appropriate docs were updated (if necessary)

Fixes #156 🦕

…of notifications

gemini-code-assist · 2025-10-30T14:50:15Z

Summary of Changes

Hello @guglielmo-san, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the system might not correctly provide a valid Task Response when a subsequent task is initiated on a task that has not yet reached a final state, particularly in non-blocking scenarios. The core change ensures that the firstResultResolver accurately captures the current Task object, enhancing the reliability of task state reporting. The addition of a new, detailed test case confirms that non-blocking follow-up tasks now correctly maintain their history and integrate artifacts as expected.

Highlights

Non-blocking Task Result Handling: Corrected the logic within _processEvents to ensure that when a firstResultResolver is active and an event of kind 'task' is processed, the current Task object is explicitly retrieved from the resultManager. This addresses an issue where the resolver might not return a valid Task Response for follow-up tasks in a non-final state.
New Test Case for Non-blocking Follow-up Tasks: Added a comprehensive test case to validate the sendMessage method's behavior when a follow-up message is sent to an existing, non-terminal task in non-blocking mode. This test verifies that the initial response correctly reflects a 'working' state and that the final task, after all events are processed, contains the complete history and any associated artifacts.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/unit-tests.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request aims to fix an issue with non-blocking calls for follow-up messages. The logic change in default_request_handler.ts correctly identifies the problem but introduces a critical bug by not handling a potential undefined return value, which could lead to runtime errors. I've provided a suggestion to fix this. Additionally, the new test case, while comprehensive, has an unconventional placement of sinon.useFakeTimers(), which I've flagged as a medium-severity issue for improved test robustness and maintainability.

ishymko

(if it was spotted via tck tests, let's link what was failing)

🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2025-11-05) ### Bug Fixes * cancel/task now returns the expected 'cancelled' task status ([#158](#158)) ([3eec0bd](3eec0bd)) * correct the default value in the agentCardPath comment ([#130](#130)) ([3279c7b](3279c7b)) * enable follow up task issue on non blocking request ([#160](#160)) ([352dc05](352dc05)) * ensure push notifications order ([#141](#141)) ([22360e6](22360e6)) * ensure user messages are added to existing tasks ([#138](#138)) ([00fb916](00fb916)) * validate JSON-RPC params ([#155](#155)) ([5b39f4d](5b39f4d)) * validate JSON-RPC request id according to the spec ([#152](#152)) ([9558c36](9558c36)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

guglielmo-san and others added 8 commits October 23, 2025 22:01

Add await on dispatchNotification to guarantee correct sending order …

cea3600

…of notifications

allow manual run of run unit test action workflow

41ee22e

add for loop in test execution

952d647

Merge branch 'a2aproject:main' into main

a1cb717

fix spacings

b61351a

Merge branch 'a2aproject:main' into main

63d70ea

Merge branch 'a2aproject:main' into main

78daf36

Change approach to return last task in blocking scenario

ad9b07e

gemini-code-assist Bot reviewed Oct 30, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts Outdated

Comment thread test/server/default_request_handler.spec.ts Outdated

guglielmo-san changed the title ~~Fix issue on non blocking result~~ fix: enable follow up task issue on non blocking request Oct 30, 2025

guglielmo-san added 2 commits October 30, 2025 20:01

Use taskStore instead of tasManager to retrieve current status of task

47cec08

fix typo

b52c606

guglielmo-san requested a review from ishymko October 30, 2025 20:13

fix tests

f2967e3

ishymko approved these changes Oct 31, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts Outdated

guglielmo-san added 2 commits October 31, 2025 15:55

remove as Message

84b5db3

Merge branch 'main' into fix_issue_on_non_blocking_result

31660a2

guglielmo-san merged commit 352dc05 into a2aproject:main Oct 31, 2025
3 checks passed

guglielmo-san deleted the fix_issue_on_non_blocking_result branch October 31, 2025 16:07

a2a-bot mentioned this pull request Oct 30, 2025

chore(main): release 0.3.5 #131

Merged

bartek-gralewicz mentioned this pull request Apr 30, 2026

chore(bgralewicz/update_release_please_for_alpha_versions): release sdk 1.0.0-alpha.0 #438

Closed

a2a-bot mentioned this pull request May 4, 2026

chore(epic/1.0_breaking_changes): release sdk 1.0.0-alpha.0 #442

Merged

a2a-bot mentioned this pull request May 12, 2026

chore(epic/1.0_breaking_changes): release 0.3.9 #463

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: enable follow up task issue on non blocking request#160

fix: enable follow up task issue on non blocking request#160
guglielmo-san merged 13 commits into
a2aproject:mainfrom
guglielmo-san:fix_issue_on_non_blocking_result

guglielmo-san commented Oct 30, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Oct 30, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

guglielmo-san commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist Bot commented Oct 30, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guglielmo-san commented Oct 30, 2025 •

edited

Loading