fix: cancel/task now returns the expected 'cancelled' task status by guglielmo-san · Pull Request #158 · a2aproject/a2a-js

guglielmo-san · 2025-10-30T10:50:31Z

Description

The current implementation of the cancel/task did not return the task in 'cancelled' status, because it was not consuming all the events on the eventBus, but was taking the last published one.
This PR fixes this tck test

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
- Important Prefixes for release-please:
  - fix: which represents bug fixes, and correlates to a SemVer patch.
  - feat: represents a new feature, and correlates to a SemVer minor.
  - feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
Ensure the tests and linter pass
Appropriate docs were updated (if necessary)

Fixes #157 🦕

…of notifications

…d task

gemini-code-assist · 2025-10-30T10:50:47Z

Summary of Changes

Hello @guglielmo-san, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the task cancellation mechanism where the cancel/task API was not consistently returning the expected 'canceled' status. The changes ensure that after a cancellation request, the system properly processes all relevant events, leading to an immediate and accurate reflection of the task's canceled state. This improves the reliability and predictability of task management within the system.

Highlights

Correct Task Cancellation Status: The cancel/task endpoint now correctly returns the 'canceled' task status, resolving an issue where it previously reported an incorrect state.
Enhanced Event Consumption: The cancellation logic has been enhanced to consume all events from the event bus, ensuring the task's state is accurately updated to 'canceled' upon completion of the cancellation process.
Robust Error Handling: Robust error handling has been added to the cancellation flow, including checks for task existence and verification that the task successfully transitions to a 'canceled' state.
Updated Unit Tests: Unit tests have been updated to reflect the corrected behavior, asserting that the cancelTask API immediately reports the 'canceled' status.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/unit-tests.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request addresses an issue where the cancel/task API was not returning the expected 'cancelled' task status. The changes ensure that all events on the eventBus are consumed until the task reaches a terminal state, guaranteeing the correct status is returned. The test case has also been updated to reflect this change. I have identified a critical issue where the task might not be cancelable due to a race condition.

ishymko

Let's update the description with appropriate failing tck test and reference implementation in Python SDK.

🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2025-11-05) ### Bug Fixes * cancel/task now returns the expected 'cancelled' task status ([#158](#158)) ([3eec0bd](3eec0bd)) * correct the default value in the agentCardPath comment ([#130](#130)) ([3279c7b](3279c7b)) * enable follow up task issue on non blocking request ([#160](#160)) ([352dc05](352dc05)) * ensure push notifications order ([#141](#141)) ([22360e6](22360e6)) * ensure user messages are added to existing tasks ([#138](#138)) ([00fb916](00fb916)) * validate JSON-RPC params ([#155](#155)) ([5b39f4d](5b39f4d)) * validate JSON-RPC request id according to the spec ([#152](#152)) ([9558c36](9558c36)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

guglielmo-san and others added 8 commits October 23, 2025 22:01

Add await on dispatchNotification to guarantee correct sending order …

cea3600

…of notifications

allow manual run of run unit test action workflow

41ee22e

add for loop in test execution

952d647

Merge branch 'a2aproject:main' into main

a1cb717

fix spacings

b61351a

Merge branch 'a2aproject:main' into main

63d70ea

Merge branch 'a2aproject:main' into main

78daf36

Consume the whole eventBus before checking the status of the cancelle…

162a703

…d task

gemini-code-assist Bot reviewed Oct 30, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts

Comment thread src/server/request_handler/default_request_handler.ts

Comment thread test/server/default_request_handler.spec.ts

Fix errors

27ab105

guglielmo-san requested a review from ishymko October 30, 2025 11:50

remove workflow dispatch

e13fc7d

ishymko reviewed Oct 30, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts

Comment thread src/server/request_handler/default_request_handler.ts

guglielmo-san added 4 commits October 30, 2025 14:55

Pass error message to non canceable task

06fac49

Add test to cover error in cancel/task

9d32b97

remove unused import

71bdce3

Fix error log

57bfef6

guglielmo-san requested a review from ishymko October 30, 2025 19:49

ishymko reviewed Oct 31, 2025

View reviewed changes

Comment thread src/server/error.ts Outdated

guglielmo-san added 2 commits October 31, 2025 16:28

revert to orignal error message

74868b9

Merge branch 'main' into fix_issue_on_cancel_task

e893a53

guglielmo-san requested a review from ishymko October 31, 2025 16:34

ishymko approved these changes Oct 31, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts

guglielmo-san merged commit 3eec0bd into a2aproject:main Nov 3, 2025
4 checks passed

guglielmo-san deleted the fix_issue_on_cancel_task branch November 3, 2025 08:00

a2a-bot mentioned this pull request Oct 31, 2025

chore(main): release 0.3.5 #131

Merged

aryaraj132 mentioned this pull request Dec 3, 2025

[Bug]: cancel task logic written in agent executor will never be called in non-blocking execution #132

Closed

1 task

bartek-gralewicz mentioned this pull request Apr 30, 2026

chore(bgralewicz/update_release_please_for_alpha_versions): release sdk 1.0.0-alpha.0 #438

Closed

a2a-bot mentioned this pull request May 4, 2026

chore(epic/1.0_breaking_changes): release sdk 1.0.0-alpha.0 #442

Merged

a2a-bot mentioned this pull request May 12, 2026

chore(epic/1.0_breaking_changes): release 0.3.9 #463

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cancel/task now returns the expected 'cancelled' task status#158

fix: cancel/task now returns the expected 'cancelled' task status#158
guglielmo-san merged 16 commits into
a2aproject:mainfrom
guglielmo-san:fix_issue_on_cancel_task

guglielmo-san commented Oct 30, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Oct 30, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

guglielmo-san commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist Bot commented Oct 30, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guglielmo-san commented Oct 30, 2025 •

edited

Loading