Skip to content

fix: validate JSON-RPC request id according to the spec#152

Merged
guglielmo-san merged 9 commits into
a2aproject:mainfrom
guglielmo-san:implement_check_on_request_id
Oct 30, 2025
Merged

fix: validate JSON-RPC request id according to the spec#152
guglielmo-san merged 9 commits into
a2aproject:mainfrom
guglielmo-san:implement_check_on_request_id

Conversation

@guglielmo-san

@guglielmo-san guglielmo-san commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR adds checks to guarantee the compliance of the request.Id parameter of JSON-RPC requests with the specifications. The identifier "MUST contain a String, Number, or NULL value if included, Numbers SHOULD NOT contain fractional parts."

This change guarantees the compliance of A2A-js as per tck tests.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #151 🦕

@guglielmo-san guglielmo-san marked this pull request as draft October 28, 2025 16:19
@gemini-code-assist

gemini-code-assist Bot commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and standard compliance of JSON-RPC request handling by introducing explicit validation for the id parameter. It ensures that the id adheres to the JSON-RPC specification, accepting only string, number (integer), or null values. This change also refactors the overall request validation into a dedicated method, making the code cleaner and more maintainable, and directly addresses compliance requirements identified by tck tests.

Highlights

  • JSON-RPC Request ID Validation: Implemented new validation checks for the request.Id parameter in JSON-RPC requests to ensure compliance with specifications. The id must be a String, Number, or NULL, and Number IDs must not contain fractional parts.
  • Refactored Request Validation: Existing JSON-RPC request validation logic (for jsonrpc version and method presence/type) has been refactored into a new private method, isRequestValid, improving code organization and reusability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 28, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the JSON-RPC request validation by moving it into a new isRequestValid method and adds checks for the id field to ensure compliance with the specification. This is a good improvement for code structure and correctness. However, I found a flaw in the new validation logic for the id field that could allow invalid requests to pass. I've provided a suggestion to create a more robust and readable validation.

Comment thread src/server/transports/jsonrpc_transport_handler.ts Outdated
@guglielmo-san guglielmo-san changed the title fix: Implement checks on JSON-RPC request.Id fix: Implement checks on JSON-RPC request Oct 28, 2025
@guglielmo-san guglielmo-san requested a review from ishymko October 28, 2025 17:17
@guglielmo-san guglielmo-san marked this pull request as ready for review October 28, 2025 17:18
@ishymko ishymko changed the title fix: Implement checks on JSON-RPC request fix: validate JSON-RPC request id according to the spec Oct 29, 2025
ishymko
ishymko approved these changes Oct 29, 2025
View reviewed changes

@ishymko ishymko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change guarantees the compliance of A2A-js as per tck tests.

If possible, can we link exact failing tests? I think that the statement as it is written now is not fully accurate (if there are other failures).

@guglielmo-san guglielmo-san merged commit 9558c36 into a2aproject:main Oct 30, 2025
3 checks passed
@guglielmo-san guglielmo-san deleted the implement_check_on_request_id branch October 30, 2025 09:34
@a2a-bot a2a-bot mentioned this pull request Oct 30, 2025
Merged
ishymko pushed a commit that referenced this pull request Nov 5, 2025
@a2a-bot
chore(main): release 0.3.5 (#131)
9a63316 
🤖 I have created a release *beep* *boop*
---


## [0.3.5](v0.3.4...v0.3.5)
(2025-11-05)


### Bug Fixes

* cancel/task now returns the expected 'cancelled' task status
([#158](#158))
([3eec0bd](3eec0bd))
* correct the default value in the agentCardPath comment
([#130](#130))
([3279c7b](3279c7b))
* enable follow up task issue on non blocking request
([#160](#160))
([352dc05](352dc05))
* ensure push notifications order
([#141](#141))
([22360e6](22360e6))
* ensure user messages are added to existing tasks
([#138](#138))
([00fb916](00fb916))
* validate JSON-RPC params
([#155](#155))
([5b39f4d](5b39f4d))
* validate JSON-RPC request id according to the spec
([#152](#152))
([9558c36](9558c36))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@bartek-gralewicz bartek-gralewicz mentioned this pull request Apr 30, 2026
Closed
@a2a-bot a2a-bot mentioned this pull request May 4, 2026
Merged
@a2a-bot a2a-bot mentioned this pull request May 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishymko ishymko ishymko approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The checks on the request.id from the JSONRpc Object are not aligned with the specifications

2 participants

@guglielmo-san @ishymko