fix: ensure user messages are added to existing tasks by benclarkeio · Pull Request #138 · a2aproject/a2a-js

benclarkeio · 2025-10-14T18:05:51Z

Ensured user messages are added to existing tasks, inline with the Python package:

Added the latest user message to an existing Task's history in the RequestContext
Added the test "should return second task with full history if message is sent to an existing, non-terminal task"
Updated README.md to check if a Task exists before publishing to the eventBus

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
- Important Prefixes for release-please:
  - fix: which represents bug fixes, and correlates to a SemVer patch.
  - feat: represents a new feature, and correlates to a SemVer minor.
  - feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
Ensure the tests and linter pass
Appropriate docs were updated (if necessary)

Fixes #136 🦕

Ensured user messages are added to existing tasks, inline with the Python package: - Added the latest user message to an existing `Task`'s history in the `ResultManager` - Added the latest user message to an existing `Task`'s history in the `RequestContext` - Added the test "should return second task with full history if message is sent to an existing, non-terminal task" - Updated `README.md` to check if a `Task` exists before publishing to the `eventBus`

gemini-code-assist · 2025-10-14T18:06:07Z

Summary of Changes

Hello @benclarkegithub, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where user messages were not consistently added to the history of existing tasks, particularly when tasks were in a non-terminal state. The changes ensure that all user messages are properly recorded in the task history, aligning the system's behavior with its Python counterpart and improving the completeness of task tracking.

Highlights

Task History Management: Ensured that the latest user message is correctly added to the history of an existing Task within the ResultManager.
Request Context Update: Implemented logic to add the latest user message to an existing Task's history in the RequestContext.
New Test Case: Added a comprehensive test case to verify that sending a message to an existing, non-terminal task correctly maintains and updates the full task history.
Event Bus Optimization: Updated the TaskExecutor and StreamingExecutor to conditionally publish initial Task objects to the eventBus only if the task does not already exist, preventing redundant events.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly ensures that user messages are added to the history of existing tasks, which is a good fix. The addition of a comprehensive test case to validate this behavior is also excellent. My main feedback is on a piece of duplicated code in the ResultManager, which should be refactored into a helper method to improve maintainability.

swapydapy · 2025-10-16T16:01:19Z

Thanks for raising this PR. Will be reviewing it in some time.

ishymko

Thank you for the PR!

…ry in `processEvent()`

ishymko

Last minor things and should be good to go!

…sk with full history ..." test

ishymko

🚀

🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2025-11-05) ### Bug Fixes * cancel/task now returns the expected 'cancelled' task status ([#158](#158)) ([3eec0bd](3eec0bd)) * correct the default value in the agentCardPath comment ([#130](#130)) ([3279c7b](3279c7b)) * enable follow up task issue on non blocking request ([#160](#160)) ([352dc05](352dc05)) * ensure push notifications order ([#141](#141)) ([22360e6](22360e6)) * ensure user messages are added to existing tasks ([#138](#138)) ([00fb916](00fb916)) * validate JSON-RPC params ([#155](#155)) ([5b39f4d](5b39f4d)) * validate JSON-RPC request id according to the spec ([#152](#152)) ([9558c36](9558c36)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

gemini-code-assist Bot reviewed Oct 14, 2025

View reviewed changes

Comment thread src/server/result_manager.ts Outdated

ishymko requested changes Oct 22, 2025

View reviewed changes

Comment thread src/server/request_handler/default_request_handler.ts

Comment thread test/server/default_request_handler.spec.ts

benclarkeio added 2 commits October 23, 2025 11:19

chore: save task in DefaultRequestHandler instead of changing histo…

6a1636b

…ry in `processEvent()`

docs: update README.md task examples with userMessage

9f72aca

benclarkeio requested a review from ishymko October 23, 2025 10:41

ishymko reviewed Oct 23, 2025

View reviewed changes

Comment thread test/server/default_request_handler.spec.ts

Comment thread src/server/result_manager.ts

chore: add artifact-update to "sendMessage: should return second ta…

48fefcf

…sk with full history ..." test

benclarkeio requested a review from ishymko October 23, 2025 12:43

chore: remove whitespace from result_manager.ts

25b2c2b

ishymko approved these changes Oct 23, 2025

View reviewed changes

ishymko merged commit 00fb916 into a2aproject:main Oct 23, 2025
4 checks passed

a2a-bot mentioned this pull request Oct 23, 2025

chore(main): release 0.3.5 #131

Merged

bartek-gralewicz mentioned this pull request Apr 30, 2026

chore(bgralewicz/update_release_please_for_alpha_versions): release sdk 1.0.0-alpha.0 #438

Closed

a2a-bot mentioned this pull request May 4, 2026

chore(epic/1.0_breaking_changes): release sdk 1.0.0-alpha.0 #442

Merged

a2a-bot mentioned this pull request May 12, 2026

chore(epic/1.0_breaking_changes): release 0.3.9 #463

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure user messages are added to existing tasks#138

fix: ensure user messages are added to existing tasks#138
ishymko merged 5 commits into
a2aproject:mainfrom
benclarkeio:main

benclarkeio commented Oct 14, 2025 •

edited by ishymko

Loading

Uh oh!

gemini-code-assist Bot commented Oct 14, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

swapydapy commented Oct 16, 2025

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benclarkeio commented Oct 14, 2025 • edited by ishymko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist Bot commented Oct 14, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

swapydapy commented Oct 16, 2025

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ishymko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benclarkeio commented Oct 14, 2025 •

edited by ishymko

Loading