fix: Add sumcheck input and opening claims to transcript#981
Merged
0xAndoroid merged 4 commits intomainfrom Oct 7, 2025
Merged
fix: Add sumcheck input and opening claims to transcript#9810xAndoroid merged 4 commits intomainfrom
0xAndoroid merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a soundness bug in the Fiat-Shamir protocol by ensuring that sumcheck input claims and opening point evaluations are properly added to the transcript. This change is critical for maintaining the security of the zero-knowledge proof system.
- Adds transcript parameter to sumcheck interfaces to enable proper Fiat-Shamir transformations
- Updates all sumcheck instances to append claims and evaluations to the transcript
- Ensures cryptographic soundness by preventing malicious provers from manipulating transcript state
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| jolt-core/src/subprotocols/sumcheck.rs | Core sumcheck trait updated with transcript parameter and claim appending |
| jolt-core/src/poly/opening_proof.rs | Opening proof accumulator methods updated to append claims to transcript |
| jolt-core/src/zkvm/spartan/*.rs | Spartan protocol sumcheck instances updated with transcript threading |
| jolt-core/src/zkvm/registers/*.rs | Register checking sumcheck instances updated with transcript parameter |
| jolt-core/src/zkvm/ram/*.rs | RAM verification sumcheck instances updated with transcript threading |
| jolt-core/src/zkvm/instruction_lookups/*.rs | Instruction lookup sumcheck instances updated with transcript parameter |
| jolt-core/src/zkvm/bytecode/*.rs | Bytecode verification sumcheck instances updated with transcript threading |
| jolt-core/src/zkvm/dag/*.rs | DAG stage management updated to handle new transcript-aware sumcheck interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8afe8ee to
712b023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fiat-shamir remains undefeated as source of soundness bugs