Don't remove unaliased hyphenated imports if they're used#1342
Merged
Conversation
Hyphenated imports, when aliased, are preserved if they're in use. However, it's supported in Go to also reference these by the package name directly without an alias if that package name doesn't have hyphens. I'm seeing issues where running `templ fmt` against files without manually-added package aliases causes these imports to get stripped away incorrectly. This change passes back the go AST and uses it to validate whether the unhyphenated package name is used for a hyphenated import. If so, we skip the deletion logic and leave that import around.
Owner
|
Nice work, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyphenated imports, when aliased, are preserved if they're in use. However, it's supported in Go to also reference these by the package name directly without an alias if that package name doesn't have hyphens. I'm seeing issues where running
templ fmtagainst files without manually-added package aliases causes these imports to get stripped away incorrectly. This change passes back the go AST and uses it to validate whether the unhyphenated package name is used for a hyphenated import. If so, we skip the deletion logic and leave that import around.