Add support for "fallthrough" in case statements#1289
Merged
Conversation
To address a-h#920 we need a new node that can consume the fallthrough keyword in templ switch statements. This adds the node, and followup diffs will add it into the parser
This also adds validation that fallthrough is only used at the end of each case statement, and validation that fallthrough isn't used on the final case statement
a-h
approved these changes
Dec 31, 2025
Owner
|
Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #920
I used the sample input to test against, and added a few validations that I also tested locally to ensure they worked.
@example(0)now properly prints<p>hey</p>The following things were included as well
This is my first contribution to the project though, so please comment away if anything can be improved!