Conversation
…e functions Fixes an issue where 'templ fmt' incorrectly added indentation to blank lines inside inline functions when used as struct field values or as arguments to templ components. The TemplElementExpression.Write method now checks if a line is blank (contains only whitespace) and skips indentation for such lines, ensuring they remain truly blank with no trailing whitespace. This makes 'templ fmt' idempotent and safe to use in CI environments.
a-h
approved these changes
Oct 19, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
templ fmtadds whitespace to blank lines when the line is:Root Cause
The
TemplElementExpression.Writemethod inparser/v2/types.gowas formatting Go expressions by comparing the original formatted code with a re-indented version. When lines were identical in both versions (which blank lines always are), it would write them with indentation. This caused blank lines to incorrectly receive tab characters.The Fix
Added a check before writing lines: if a line is blank (contains only whitespace when trimmed), skip indentation and continue to the next line. This ensures blank lines remain truly blank with no trailing whitespace.
Changes
TemplElementExpression.Writeinparser/v2/types.goto check for blank linesinline_func_blank_lines_no_whitespace.txtTesting
templ fmtcan now be safely used in CI without introducing unwanted whitespaceCloses #1165