Add Ranges to IfExpression and ElseIfExpressionparser nodes#1248
Merged
Add Ranges to IfExpression and ElseIfExpressionparser nodes#1248
Ranges to IfExpression and ElseIfExpressionparser nodes#1248Conversation
Contributor
Author
|
Hi, it's been a while on this PR, wanted to check in. @a-h you mind taking a look? |
a-h
approved these changes
Sep 12, 2025
Owner
|
Sorry about the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, back with another set of
Rangeadditions, this time forIfExpressionandElseIfExpressionparser nodes.I'll forgo the additional linter use notes unless you'd like me to add that context.
Thank you very much for the reviews!