fix: add support for spreading non-string attribute values in RenderAttributes#1213
Merged
fix: add support for spreading non-string attribute values in RenderAttributes#1213
Conversation
…ttributes - Add support for all numeric types (ints, uints, floats, complex) in RenderAttributes - Use fmt.Sprint to convert numeric values to strings before rendering - Add comprehensive unit tests for RenderAttributes function - Add integration test for numeric attribute types in spread attributes - Fixes issue where only string/bool values were rendered in spread attributes Fixes #1212
a-h
commented
Jul 3, 2025
- Remove unnecessary section comments from RenderAttributes - Add t.Parallel() to make tests run in parallel - Format code with go fmt
Use the existing generic ptr[T any] function instead of specific stringPtr and boolPtr functions to reduce code duplication.
- Add support for int, uint, float, and complex types in RenderAttributes - Add comprehensive unit tests for all numeric attribute types - Add integration test for numeric attribute spreading - Use generic ptr function for test pointer helpers - All tests run in parallel and pass Fixes #1212
RyanBurkeIW
reviewed
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for all numeric types (ints, uints, floats, complex) in RenderAttributes function.
Changes
Problem
Previously, only string and boolean values were rendered when using spread attributes. Numeric values like integers and floats were ignored.
Solution
Extended the switch statement in RenderAttributes to handle all types from the stringable interface by converting them to strings using fmt.Sprint().
Testing
Fixes #1212