Conversation
Collaborator
|
Great, this all looks good. Thanks as always for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new Templ file is created, it can take a moment for
GOPACKAGESDRIVERto detect that the file belongs to a specific Go package—typically after the package clause is added at the top of the file.Until this happens, any requests that depend on package context, such as
textDocument/codeAction, are likely to fail. This isn't a problem in isolation, but when a user creates a new file and starts typing before the package is recognized, the client continues to sendtextDocument/codeActionrequests on each keystroke. Since the server can't resolve the file's package, each request fails, and the user is bombarded with failure notifications in VS Code, which quickly becomes annoying.To avoid this, ignore
textDocument/codeActionrequests for Templ files that haven't yet been loaded by the lazy loader.