Refactor cancellation logic into a separate section#1191
Closed
philip-peterson wants to merge 2 commits intoa-h:mainfrom
Closed
Refactor cancellation logic into a separate section#1191philip-peterson wants to merge 2 commits intoa-h:mainfrom
philip-peterson wants to merge 2 commits intoa-h:mainfrom
Conversation
Contributor
philip-peterson
commented
Jun 12, 2025
- Since the logic is semantically a separate section, moves cancellation into a new function.
- Because variables can be moved closer to their usages, moves a couple variable declarations down.
philip-peterson
commented
Jun 12, 2025
| errs <- FatalError{Err: fmt.Errorf("failed to walk files: %w", err)} | ||
| return | ||
| } | ||
| close(fileEvents) // TODO should this be defer'red? |
Contributor
Author
There was a problem hiding this comment.
Should this close be in a defer, since an error could cause an early return and never close the channel?
Owner
|
I've done a major refactor in #1227 to hopefully make the intent of all that code a lot clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.