Refactor filesystem event handler into a separate section#1190
Closed
philip-peterson wants to merge 2 commits intoa-h:mainfrom
Closed
Refactor filesystem event handler into a separate section#1190philip-peterson wants to merge 2 commits intoa-h:mainfrom
philip-peterson wants to merge 2 commits intoa-h:mainfrom
Conversation
Owner
|
I've done a major refactor in #1227 to hopefully make the intent of all that code a lot clearer. Thanks a lot for your contribution here, it was the trigger to make me totally rethink the structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the generatecmd::Run function into two functions, to reduce complexity. In doing so, I noticed that a few instances of error handling operate by defining a new variable
errand logging and/or returning it immediately, while another instance assigns the preexisting symbolerrwhich represents the return value. Because this logic was very unclear, I renamed the top-levelerrtoproxyError(since it is only used for the proxy) and removed the named-return value so that any assignment toerrmust be its own contained definition to make for better readability.The diff shows that
StartProxywas changed (actually moved), but that is just due to the addition of a new function (and removal of part of another) which confuses the Git diff algorithm.