Conversation
eb83a71 to
feebc2a
Compare
joerdav
commented
Jun 10, 2025
| return | ||
| } | ||
| // Move past the end element. | ||
| _, _, _ = goSingleLineCommentEnd.Parse(pi) |
Collaborator
Author
There was a problem hiding this comment.
Everything in this file apart from these 2 deletions are just formatting nits.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that comment parsers no longer consume trailing newlines and updates tests to expect explicit newline whitespace nodes.
- Added explicit newline whitespace expectations in template parser tests
- Introduced a new if‐expression test covering else‐branch comments and indentation
- Refactored the Go comment parser to stop eating newlines and cleaned up var/type declarations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parser/v2/templateparser_test.go | Added Whitespace{Value: "\n"} to the comment’s child nodes |
| parser/v2/ifexpressionparser_test.go | Added a test case for else with a comment and indentation |
| parser/v2/gocommentparser.go | Removed end‐of‐line consumption from single‐line comment parser and grouped var/type declarations |
Comments suppressed due to low confidence (1)
parser/v2/gocommentparser.go:7
- This var block has manually aligned assignments that won’t be preserved by
gofmt. Consider runninggofmt(orgo fmt) to normalize formatting and remove manual alignment.
var (
a-h
approved these changes
Jun 10, 2025
Owner
|
Legend. Thanks. |
|
Wow, speedy! Thanks!. |
Collaborator
Author
|
Pleasure, not often you get to fix a bug just by deleting code :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1182