fix(lsp): set range on invalid parse results, fixes #1176#1178
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the range setting for invalid parse results in the LSP by refactoring the range assignment logic in the parser functions and updating the associated tests. Key changes include:
- Using defer blocks to assign the Range field in HTMLTemplate, ScriptTemplate, and CSSTemplate parsers.
- Removing redundant manual assignments to r.Range.
- Updating tests to check for the new range values.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| parser/v2/templatefile_test.go | Adds test assertions to verify the updated range values. |
| parser/v2/scripttemplateparser.go | Refactors range assignment to use defer, removing duplicate code. |
| parser/v2/parser.go | Applies similar refactoring for range assignment in HTML templates. |
| parser/v2/cssparser.go | Uses defer to set range and removes redundant assignment. |
| .version | Updates the version number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.