Merged
Conversation
Tables were previously no-ops (all table tokens explicitly set to `break`). This patch implements complete table support: - Inserts a properly-sized table via the Google Docs insertTable API - Populates each cell with text content - Supports inline formatting (bold, italic, links) within cells - Applies bold formatting to header rows automatically - Handles tables of arbitrary row/column count Key index formulas verified against the Docs API structure: cellContentIndex(T, r, c, C) = T + 4 + r * (1 + 2*C) + 2*c emptyTableSize(R, C) = 3 + R * (1 + 2*C) Tested with an 8-table document (mixed column counts) pushed to Google Drive via replaceDocumentWithMarkdown — all tables rendered correctly with bold headers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breakinmarkdownToDocs.ts, so any markdown table was silently droppedinsertTableAPI, then populates each cell with text and inline formattingImplementation details
The core challenge is that the Google Docs API requires knowing all indices upfront before inserting text, and inserting content shifts all subsequent indices. The approach:
TableStatestructure rather than emitting requests immediatelytable_close— emit oneinsertTablerequest, then iterate all cells in order, tracking cumulative inserted character counts to compute correct absolute indicesKey index formulas (verified against the Docs API table structure):
Testing
Tested with an 8-table document (mixed column counts, bold/italic inline formatting in cells) pushed to Google Drive via
replaceDocumentWithMarkdown. All tables rendered correctly with bold header rows.Before this patch, the same document produced garbled output with all table content concatenated into the surrounding paragraph text.
Notes
replaceDocumentWithMarkdownexercises the full transformer path —createDocumentwithcontentFormat: "markdown"also works for tables via this same transformer