This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Address types that compare equal must be structurally equal #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the test IPC server to return false on "not found" as per the latest protocol with the blockchain IPC server. Errors are to be raised only for things such as database error, invalid request etc.
anton-trunov
approved these changes
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by representing addresses using Maps rather than lists. Maps bring in an order.
Also update the test IPC server to return false on "not found" as per the latest protocol with the blockchain IPC server. Errors are to be raised only for things such as database error, invalid request etc.