This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Bugfix: Shadowing of imported names is allowed #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disambiguator reported a error when a local library definition shadowed an imported definition, e.g., when a contract library imports
ListUtilsbut then redefineslist_length.This has now been fixed, although it required a bit of refactoring to lift the culpable line of code out to the point where it could be avoided (the check is still needed to avoid multiple imports of the same name).
Note that the disambiguator allows shadowing of type and constructor names. However, the recursion check (via DatatypeDictionary) reports an error on them.