This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Use DataTypeDictionary to keep track of ADTs in scope during recursion check #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivaswatha
approved these changes
Nov 23, 2020
…lla into nested_type_import_bug
anton-trunov
approved these changes
Nov 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes the bug where ADTs in nested imports were not added correctly to DataTypeDictionary while in scope.
@vaivaswatha : I have tested this using your Polynetwork standard library files. We have tests in our test suite that check for the cases where a module imports a name and also defines that same name, but we are missing the following cases:
Ximports an ADTTfrom a different library, and the contract that importsXalso definesT(this is allowed). When the contract usesT, then it should refer to the locally defined type and not the nested import. (Same story for constructor names)I'll add these testcases, but do you want me to merge this PR before I add them, so that you are no longer blocked?