Conversion builtins for ByStrX to UIntX #907
Conversation
Co-authored-by: Anton Trunov <anton@zilliqa.com>
Co-authored-by: Anton Trunov <anton@zilliqa.com>
| let int_bit_width_to_int = function | ||
| | Bits32 -> 32 | ||
| | Bits64 -> 64 | ||
| | Bits128 -> 128 | ||
| | Bits256 -> 256 | ||
|
|
There was a problem hiding this comment.
We also have the int_width function further below in Types.ml:
let int_width = function
| PrimType (Int_typ Bits32) | PrimType (Uint_typ Bits32) -> Some 32
| PrimType (Int_typ Bits64) | PrimType (Uint_typ Bits64) -> Some 64
| PrimType (Int_typ Bits128) | PrimType (Uint_typ Bits128) -> Some 128
| PrimType (Int_typ Bits256) | PrimType (Uint_typ Bits256) -> Some 256
| _ -> NoneIs it possible to reuse int_bit_width_to_int to simplify it into something like this?
let int_width = function
| PrimType (Int_typ bits) | PrimType (Uint_typ bits) -> Some (int_bit_width_to_int bits)
| _ -> None| let res7 = builtin to_uint32 zero in | ||
| let res8 = builtin to_uint32 one_1 in | ||
| let res9 = builtin to_uint32 one_3 in | ||
| let res10 = builtin to_uint32 one_4 in | ||
| let res11 = builtin to_uint256 one_1 in | ||
| let res11 = builtin to_uint256 one_8 in |
There was a problem hiding this comment.
As far as I understand, this PR adds to_uint64 / to_uint128 (and the signed versions too). If this is correct, could we have those tested too, please?
There was a problem hiding this comment.
Added now for other unsigned ones. I didn't add the builtin itself for signed versions. I'm not convinced we need them. If we do add, we do sign extend if the input bystrx is smaller in size? Not sure. That's why I've left it for now.
|
@anton-trunov I've addressed your comments, and in addition added |
|
@vaivaswatha Awesome! Thanks. |
No description provided.