Skip to content
This repository was archived by the owner on Aug 27, 2025. It is now read-only.

Eval minor refactoring #883

Merged
anton-trunov merged 4 commits into from
Aug 26, 2020
Merged

Eval minor refactoring #883

anton-trunov merged 4 commits into from
Aug 26, 2020

Conversation

@anton-trunov
Copy link
Contributor

@anton-trunov anton-trunov commented Aug 26, 2020

  • Added monadic projections fstM and sndM
  • In MonadUtils 
    let%bind foo = bar in
pure foo
    refactored into 
    let%map foo = bar in foo
    This is especially useful when there are several independent let%bind expressions in a row because let%map also reflects that.
  • Minor refactoring in Eval, this is mostly about using Env.bind_all because it's much easier to read compared to List.fold_left ....

@anton-trunov anton-trunov merged commit 221d7c7 into master Aug 26, 2020
@anton-trunov anton-trunov deleted the eval-minor-refactoring branch August 26, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jjcnn jjcnn Awaiting requested review from jjcnn

1 more reviewer

@vaivaswatha vaivaswatha vaivaswatha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anton-trunov @vaivaswatha