The latest commit further changes yamlInSelection into a more generic function for checking if a list of nodes is within a selection. It is now called nodeInSelection, and an additional helper was added posInSelection, both of which consolidate logic used in a few places in the code

I appreciate this, especially ensuring that YAML frontmatters won't contain tab characters anymore.

However, I think we should spend at least a little bit on discussing the implementation, because — at least for me, personally — this PR would prove to be an unwanted change. To elaborate a bit:

Tab characters stem from a time when we didn't have tables and proper alignment, so they have lost their original meaning. Nowadays, they mostly are used to switch between program tabs, or to indent/unindent lists, but even this indentation is at least half of the time done with spaces. So, oftentimes, they are at the very least not necessary and thus a matter of preference.

If I understand you correctly, this would change the behavior so that, when one is somewhere within a line, this would no longer indent the line, but instead insert a literal tab character. This would be a regression, because I have grown accustomed to just clicking somewhere in a line to indent/unindent it.

However, I fully understand and support workflows that rely on tabs instead of spaces, so I am more than happy to implement this, but with some changes.

Thus, I have two refactoring requests:

1. Please separate the switching-off of tabs in the frontmatter from the indentation logic, if possible. (This might necessitate two separate commands both bound to Tab with a fall-through like behavior, I apologize for this in advance. But maybe this could be done within a single command…?)
2. Allow toggling of this behavior, with the default being the current behavior (i.e., always indent/unindent, never inserting a space). You can just amend the existing config objects and add this setting to the other section of the editor settings (unless you find a better place).

Thank you!

Sure, I can make it configurable. I think it should default to allowing inserting tabs/spaces in the text, since it would otherwise be a big change from previous Zettlr behavior, which currently allows inserting tabs.

I don't think I should separate out the YAML logic, though. The YAML case would be an exact duplicate, except for the YAML check.

If I understand you correctly, this would change the behavior so that, when one is somewhere within a line, this would no longer indent the line, but instead insert a literal tab character. This would be a regression, because I have grown accustomed to just clicking somewhere in a line to indent/unindent it.

Just to clarify, this would only be a regression from the changes in #6168. Before that PR, Zettlr used the codemirror insertTab, which either inserts a literal tab, or indents the line if the selection is non-empty.

Another point -- there are three places in the code that could re-use the new posInNode function. I will save those refactors for a separate review, unless you think I should include them here.

• Zettlr/source/common/modules/markdown-editor/commands/autocorrect.ts

  Lines 25 to 58 in a73f0dc

  	/**
  	* Given the editor state and a position, this function returns whether the
  	* position sits within a node that is protected from autocorrect. In those
  	* cases, no autocorrection will be applied, regardless of whether there is a
  	* suitable candidate.
  	*
  	* @param {EditorState} state The state
  	* @param {number} pos The position to check
  	*
  	* @return {boolean} True if the position touches a protected node.
  	*/
  	function posInProtectedNode (state: EditorState, pos: number): boolean {
  	const PROTECTED_NODES = [
  	'InlineCode', // `code`
  	'Comment', 'CommentBlock', // <!-- comment -->
  	'FencedCode', 'CodeText', // Code block
  	'HorizontalRule', // --- and ***
  	'YAMLFrontmatter',
  	'HTMLTag', 'HTMLBlock' // HTML elements
  	]
  	let node = syntaxTree(state).resolveInner(pos, -1)
  	while (node.parent !== null) {
  	if (PROTECTED_NODES.includes(node.type.name)) {
  	return true
  	}
  	node = node.parent
  	}
  	// Neither the node itself, nor any of its parents, are protected.
  	return false
  	}

• Zettlr/source/common/modules/markdown-editor/plugins/default-context-menu.ts

  Lines 23 to 46 in a73f0dc

  	/**
  	* Takes an EditorView and a position within it, and returns either a SyntaxNode
  	* of type URL, Link, or Image, or null. This information can be used to
  	* determine whether there is any form of Link or image at the given position.
  	*
  	* @param {EditorView} view The editor view
  	* @param {number} pos The position to check
  	*
  	* @return {SyntaxNode|null} Either a Link, Image, or URL syntax node, or null.
  	*/
  	function getLinkOrImageNodeFromPos (view: EditorView, pos: number): SyntaxNode|null {
  	const node = syntaxTree(view.state).resolveInner(pos)
  	if ([ 'URL', 'Link', 'Image' ].includes(node.type.name)) {
  	return node
  	}
  	let nodeAt: SyntaxNode|null = node
  	while (nodeAt !== null && ![ 'Link', 'Image', 'LinkReference' ].includes(nodeAt.type.name)) {
  	nodeAt = nodeAt.parent
  	}
  	return nodeAt
  	}

• Zettlr/source/common/modules/markdown-editor/tooltips/hyperlinks.ts

  Lines 32 to 45 in a73f0dc

  	/**
  	* Displays a tooltip for URLs and Links across a document
  	*/
  	export function urlTooltip (view: EditorView, pos: number, side: 1 | -1): Tooltip|null {
  	let nodeAt = syntaxTree(view.state).cursorAt(pos, side).node
  	// If the node here is a URL, it's quick, but if not, it must be a Link node
  	// that contains a URL as a child
  	if (nodeAt.type.name !== 'URL') {
  	// First, navigate to one of the two possible parent nodes.
  	while (nodeAt.parent !== null && ![ 'Link', 'LinkReference' ].includes(nodeAt.type.name)) {
  	nodeAt = nodeAt.parent
  	}

Sure, I can make it configurable. I think it should default to allowing inserting tabs/spaces in the text, since it would otherwise be a big change from previous Zettlr behavior, which currently allows inserting tabs.

I don't think I should separate out the YAML logic, though. The YAML case would be an exact duplicate, except for the YAML check.

If I understand you correctly, this would change the behavior so that, when one is somewhere within a line, this would no longer indent the line, but instead insert a literal tab character. This would be a regression, because I have grown accustomed to just clicking somewhere in a line to indent/unindent it.

Just to clarify, this would only be a regression from the changes in #6168. Before that PR, Zettlr used the codemirror insertTab, which either inserts a literal tab, or indents the line if the selection is non-empty.

Oh god, I completely overlooked that, which might be due to me never wanting Tabs in my files, so I didn't realize this. So yes, your change is correct. Let me go through this again, because given the fact that it worked the last years without me complaining means it worked as intended. So no need to make this configurable.

Ah I see you made it configurable already. Then let's keep that, it can't hurt, and this way your effort wasn't wasted!

Thank you!