[Enhancement] Improve pdf viewer resize UX#6153
Merged
Merged
Conversation
Member
|
Huh, smart! Thanks a bunch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how the PDF viewer determines whether to accept
pointer-eventsto improve UX when resizing the editor pane.Changes
Instead of watching for focus changes,
acceptClicksis now toggled onpointerenterandpointerleave. This improves UX in two ways: the user no longer has to remember to unfocus the viewer before resizing, and the user no longer has to click to focus the viewer before using the UI.The border around the active viewer has been removed because it no longer serves a purpose.
overflow: hiddenwas added to the iframe parent element to prevent scroll bars from appearing on the parent.Additional information
PR (still with the border present):
Screen.Recording.2026-01-26.at.20.42.45-1.mov
Tested on: