[Fix] Reduce config retrieval throttling#6140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the config retrieval throttling from
1 secondto50msto improve UX and fix some minor issues.Changes
The retrieval throttling was reduced from
1 secondto50ms. The long throttle caused UX side effects, such as a 1-second delay when switching tabs in the sidebar. It also caused an issue I was experiencing where quickly checking or unchecking spellcheck dictionaries would not be registered,and unselecting all dictionaries was not possible.[EDIT: this last part was an erroneous issue] This is no longer the case with the reduced throttle.Additional information
The throttle was initially put in place to reduce lag from rapid config updates. I wasn't able to produce any lag with
50ms, but if there is, the value should be increased by smaller increments, as1 secondis too long.Tested on: macOS 26