[Feat] Add utilities for pandoc divs and spans -- Part 2#6032
Merged
Conversation
393fd4c to
6ce2f08
Compare
Member
|
Quick heads up: Going to postpone this to after 4.0! |
8ceaf3d to
e2117f7
Compare
nathanlesage
requested changes
Jan 13, 2026
nathanlesage
left a comment
Member
There was a problem hiding this comment.
Looks good and adds a ton of value, there are just a few minor things to change (plus one potentially larger refactor).
Collaborator
Author
|
Its been a minute since I really looked through this, but I agree with pretty much all your comments! I'll dedicate some time to this over the next couple days to respond in detail |
* update name scheme from `fence`/`bracket` to `div`/`span` * restore highlight default to `==` * re-organize code
nathanlesage
requested changes
Jan 14, 2026
nathanlesage
left a comment
Member
There was a problem hiding this comment.
We're getting there. I really like how this is developing! :)
* strip braces if the string has them, otherwise * process the attributes as usual
* removed some braces from tests * simplified test structure since the function no longer errors
nathanlesage
approved these changes
Feb 7, 2026
nathanlesage
left a comment
Member
There was a problem hiding this comment.
So, now, finally. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds utilities for pandoc fenced divs and bracketed spans, including formatting bar improvements and a popover utilty.
See #5848 for more information
Changes
Additional information
Tested on: