[Refactor] Move FSAL cache to async#5994
Merged
Merged
Conversation
5 tasks
1d04190 to
0e38479
Compare
0e38479 to
827588d
Compare
827588d to
df32958
Compare
nathanlesage
requested changes
Dec 28, 2025
nathanlesage
left a comment
Member
There was a problem hiding this comment.
Found a few possibly problematic things, but other than that I can't see too many things bad about this!
df32958 to
68f94ae
Compare
nathanlesage
left a comment
Member
There was a problem hiding this comment.
I've now seen what you mean with making the emitChokidarEvent function async, but unfortunately that won't work as expected :/
I think, simply keeping the catch-handlers and logging any errors is the most suitable approach here.
4998f6d to
e65ceb0
Compare
Collaborator
Author
|
This is good to go on my end! |
Member
|
Looks good! Let's go with it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the FSAL cache code to
asyncfunctions.Changes
The FSAL cache code was migrated to use
asyncfunctions.A couple of external functions which use the FSAL cache were updated to match the new async pattern.
Additional information
The main motivation was to take advantage of async
readFileandlstat. In my tests loading a large workspace, the time went from89 seconds to 3 seconds to load.EDIT: The claim in speed improvements may be erroneous, as after a few restarts on the develop branch, I no longer experienced the same long load times that led me down this path. Both implementations provide approximately the same performance, in my small amount of testing.
Async is not my strong suit, so I may have missed something in the port!
Tested on: macOS 26