pythongh-130327: Only set the managed dictionary if there aren't inline values

ZeroIntensity · ZeroIntensity · commit 8a29421ba500 · 2025-02-19T21:05:01.000-05:00
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -7170,15 +7170,16 @@ set_dict_inline_values(PyObject *obj, PyDictObject *new_dict)
 
     PyDictValues *values = _PyObject_InlineValues(obj);
 
-    Py_XINCREF(new_dict);
-    FT_ATOMIC_STORE_PTR(_PyObject_ManagedDictPointer(obj)->dict, new_dict);
-
     if (values->valid) {
         FT_ATOMIC_STORE_UINT8(values->valid, 0);
         for (Py_ssize_t i = 0; i < values->capacity; i++) {
             Py_CLEAR(values->values[i]);
         }
     }
+    else {
+        Py_XINCREF(new_dict);
+        FT_ATOMIC_STORE_PTR(_PyObject_ManagedDictPointer(obj)->dict, new_dict);
+    }
 }
 
 #ifdef Py_GIL_DISABLED

Original file line number	Diff line number	Diff line change
`@@ -7170,15 +7170,16 @@ set_dict_inline_values(PyObject obj, PyDictObject new_dict)`
`7170`	`7170`
`7171`	`7171`	`PyDictValues *values = _PyObject_InlineValues(obj);`
`7172`	`7172`
`7173`		`- Py_XINCREF(new_dict);`
`7174`		`- FT_ATOMIC_STORE_PTR(_PyObject_ManagedDictPointer(obj)->dict, new_dict);`
`7175`		`-`
`7176`	`7173`	`if (values->valid) {`
`7177`	`7174`	`FT_ATOMIC_STORE_UINT8(values->valid, 0);`
`7178`	`7175`	`for (Py_ssize_t i = 0; i < values->capacity; i++) {`
`7179`	`7176`	`Py_CLEAR(values->values[i]);`
`7180`	`7177`	`}`
`7181`	`7178`	`}`
	`7179`	`+ else {`
	`7180`	`+ Py_XINCREF(new_dict);`
	`7181`	`+ FT_ATOMIC_STORE_PTR(_PyObject_ManagedDictPointer(obj)->dict, new_dict);`
	`7182`	`+ }`
`7182`	`7183`	`}`
`7183`	`7184`
`7184`	`7185`	`#ifdef Py_GIL_DISABLED`